fix(minifier): keep variables that are modified by typeof foo === 'object' && foo !== null compression (2)#13362
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 29, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 28, 2025
CodSpeed Instrumentation Performance ReportMerging #13362 will not alter performanceComparing Summary
Footnotes |
Contributor
Merge activity
|
…bject' && foo !== null` compression (2) (#13362) `typeof foo === 'object' && foo !== null` compression was not keeping the reference information and that caused used variables to be removed, similar to #13290. ```js var bar = foo.bar; if (typeof bar !== 'object' || bar === null) console.log('foo') ``` was compressed into ```js if (typeof foo.bar !== 'object' || bar === null) console.log('foo') ``` refs #13290
graphite-app
bot
force-pushed
the
08-29-feat_minifier_inline_top-level_variables_for_module_scripts
branch
from
fe63e95 to
56d2da3
Compare
graphite-app
bot
force-pushed
the
08-29-fix_minifier_keep_variables_that_are_modified_by_typeof_foo_object_foo_null_compression_2_
branch
from
b1be28e to
72468f9
Compare
Base automatically changed from
08-29-feat_minifier_inline_top-level_variables_for_module_scripts
to
main
August 29, 2025 02:53
graphite-app
bot
deleted the
08-29-fix_minifier_keep_variables_that_are_modified_by_typeof_foo_object_foo_null_compression_2_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeof foo === 'object' && foo !== nullcompression was not keeping the reference information and that caused used variables to be removed, similar to #13290.was compressed into
refs #13290